Fix extrusion hole assignment for nested sketch regions - #88
Open
WC3D wants to merge 1 commit into
Open
Conversation
Assign holes to outlines per selected region instead of inferring nesting from outline areas. The area heuristic mis-grouped profiles inside a sketch (for example an overlapping or unselected inner profile), so editing a sketch and toggling region selection could produce wrong geometry. Regions now carry their own outer/hole paths, and each selected region extrudes exactly as shown.
mhaeu
pushed a commit
to mhaeu/SketchForge-3D
that referenced
this pull request
Sep 9, 2026
Assign holes to outlines per selected region instead of inferring nesting from outline areas. The area heuristic mis-grouped profiles inside a sketch (for example an overlapping or unselected inner profile), so editing a sketch and toggling region selection could produce wrong geometry. Regions now carry their own outer/hole paths, and each selected region extrudes exactly as shown. Applied-from: Formsmith746#88 (upstream nicht gemergt) Applied-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a sketch contains nested profiles, the fallback mesh extrusion independently inferred hole nesting from outline areas. That duplicated region logic and could mis-group outlines, producing incorrect extrusion geometry.
The fallback extrusion now uses the existing
cadSketchRegionsresult as the source of truth, assigning each region's hole paths directly to its outer boundary.This is the holes/extrusion fix from #76, separated from the sketch menu changes in #74 and based directly on
main.Validation:
npm run typechecknpm test -- --run tests/unit/sketchCadProfile.test.tsnpm run test:e2e -- --run tests/e2e/sketchCadExtrusion.e2e.ts