Improve typing and docs recommendation #245
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During some tests inside my app, i think its better to hold the
app.ts
file cleaner and moving setups to an extra file like we did before.In additional we need to allow passing
IconDefinition
as@icon
to component.We have already a use case for that inside test-app and maybe peoples were already using it.
Passing
IconDefinition
is very interesting, when consumer apps are using template-tag (strict mode) in ember (which is part of polaris edition and can be used already), because this make at the end thefont-awesome.ts
nearly unnecessary (just the setup forfaConfig.autoAddCss = false;
is needed.Its more a choise for consumer apps, if they want register icons and consume with string or importing icon directly at each point.
Changes in this PR:
IconDefinition
IconDefinition