Skip to content

feat(deps): upgrade to typescript v6 #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
charles4221 wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −9
Open

feat(deps): upgrade to typescript v6 #642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@
"typedoc-plugin-merge-modules": "^7.0.0",
"typedoc-plugin-missing-exports": "^4.1.3",
"typedoc-plugin-umami-analytics": "^1.0.1",
"typescript": "^5.9.3",
"typescript": "^6.0.3",
"typescript-eslint": "^8.58.2"
},
"files": [
Expand Down
4 changes: 0 additions & 4 deletions src/components/FontAwesomeIcon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,13 +120,9 @@ export const FontAwesomeIcon = React.forwardRef<
// @ts-expect-error since `key` can be any of the keys in FontAwesomeIconProps,
// TypeScript widens the type of the `obj[key]` lookups to a union of all possible values,
// which will not correctly overlap each other.
// TODO: remove eslint-disable when react hooks rules are fixed properly to stop false flags on refs
// eslint-disable-next-line react-hooks/refs
extraProps[key] = allProps[key]
}

// TODO: remove eslint-disable when react hooks rules are fixed properly to stop false flags on refs
// eslint-disable-next-line react-hooks/refs
return makeReactConverter(abstract[0], extraProps)
})

Expand Down
Loading