feat(email): EMAIL-001 メールテンプレート管理機能の実装#34
Merged
f0reachARR merged 10 commits intomainfrom Apr 23, 2026
Merged
Conversation
…ルテンプレートを集約管理 - interface.ts: EmailTemplateMap / SendEmailTemplateParams 型定義追加 - テンプレートID + ペイロードで送信指定できる型安全なAPIを追加 - SendEmailParams は既存の SendEmailContentParams との判別共用体 - console.ts / sendgrid.ts: resolveSendEmailParams でテンプレートを解決してから送信 - auth.ts, routes/university.ts, routes/admin/universities.ts, routes/admin/requests.ts: 招待メール送信箇所を template + payload 形式に置き換え - テスト: templates.test.ts / sendgrid.test.ts 追加、console.test.ts / app.issue11 更新
There was a problem hiding this comment.
Code Review
This pull request updates the GitHub agent configurations, refactors the backend email service to use a template-based system, and introduces a series filter to the admin editions page in the frontend. The email refactoring includes new template definitions, updated service interfaces, and comprehensive tests. Feedback is provided regarding a potential HTML injection vulnerability in the email template rendering and a suggestion to use the standard placeholder property for the frontend Select component to improve reliability and reduce redundancy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
Issue #33 (EMAIL-001) の実装。emailService.sendEmail にテンプレートベースの送信APIを追加し、招待メール4経路の呼び出し側を「テンプレートID + ペイロード」形式に統一しました。
Closes #33
変更点
新規追加
変更
テスト結果
Test Files 3 passed (3)
Tests 8 passed (8)
Duration 147ms
受け入れ条件チェック