add retry logic to API#42
Merged
f0reachARR merged 1 commit intomainfrom Apr 27, 2026
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors S3 metadata retrieval by moving retry logic from the storage service into the submissions route handler and simplifying the service method. Feedback highlights that the new retry implementation is inefficient because it catches all errors instead of specific retryable ones, and that moving this logic out of the service layer reduces modularity. Additionally, the removal of unit tests for the retry mechanism was flagged as a regression in test coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.