Skip to content

add retry logic to API#42

Merged
f0reachARR merged 1 commit intomainfrom
fix/retry-storage-2
Apr 27, 2026
Merged

add retry logic to API#42
f0reachARR merged 1 commit intomainfrom
fix/retry-storage-2

Conversation

@f0reachARR
Copy link
Copy Markdown
Member

No description provided.

@f0reachARR f0reachARR enabled auto-merge April 27, 2026 14:54
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors S3 metadata retrieval by moving retry logic from the storage service into the submissions route handler and simplifying the service method. Feedback highlights that the new retry implementation is inefficient because it catches all errors instead of specific retryable ones, and that moving this logic out of the service layer reduces modularity. Additionally, the removal of unit tests for the retry mechanism was flagged as a regression in test coverage.

Comment thread apps/backend/src/routes/submissions.ts
Comment thread apps/backend/src/services/storage.ts
Comment thread apps/backend/src/services/storage.test.ts
@f0reachARR f0reachARR merged commit 1650d6c into main Apr 27, 2026
2 checks passed
@f0reachARR f0reachARR deleted the fix/retry-storage-2 branch April 27, 2026 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant