Skip to content

Add an Int extension function to adjust sim color against dark background #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2025

Conversation

ycorre
Copy link
Contributor

@ycorre ycorre commented Mar 8, 2025

What is it?

  • Bugfix
  • Feature
  • Codebase improvement

Description of the changes in your PR

Add an extension that brightens sim color against dark background to improve readability.

I intend to finish the PR FossifyOrg/Phone#27 which seemed to be abandoned since there was no update for over a year now. It was almost finished and was only needing to move the code included in this PR to an extension in the Commons repository since it can also be used in the Messages app.

I hope this is OK, I will add a new PR in the Phone repository with the code to complete original PR.

Also, since the code added is not mine, I put a reference to the original commit in the commit message in order to credit the original author.

Acknowledgement

@naveensingh
Copy link
Member

Hey, thanks for the PR!

I hope this is OK, I will add a new PR in the Phone repository with the code to complete original PR.

I don't think that will be required as that PR is already supposed to be complete. I just didn't have enough time/motivation to review/merge but I plan to merge it before the next release.

@naveensingh naveensingh merged commit e786b2b into FossifyOrg:master Mar 8, 2025
2 of 4 checks passed
@ycorre ycorre deleted the adjust-sim-color branch March 8, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants