Upgrade SDK to 4.0 #316
Merged
Upgrade SDK to 4.0 #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
Upgrades the AWS SDK to v4.0 and adapts code for new nullable APIs, JSON handling, and C# 12 syntax.
- Swapped
FallbackCredentialsFactoryforDefaultAWSCredentialsIdentityResolveracross S3 and SQS. - Made AWS responses (e.g.,
LastModified,IsTruncated,Messages) null-safe and replaced LitJson withSystem.Text.Json. - Adopted C# 12 collection expressions and
JsonObjectfor redrive policy serialization.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Foundatio.AWS/Storage/S3FileStorage.cs | Updated credential resolution, null-safe LastModified conversion, and used collection expression for DeleteObjectsRequest.Objects. |
| src/Foundatio.AWS/Queues/SQSQueueEntry.cs | Added null check before iterating MessageAttributes. |
| src/Foundatio.AWS/Queues/SQSQueue.cs | Migrated credentials, JSON construction with JsonObject, null-safe message handling, and C# 12 enhancements. |
| src/Foundatio.AWS/Queues/AttributeExtensions.cs | Removed LitJson, switched to JsonDocument for parsing RedrivePolicy. |
| src/Foundatio.AWS/Foundatio.AWS.csproj | Bumped AWS SDK package versions to 4.x. |
| src/Foundatio.AWS/Extensions/Extensions.cs | Null-safe mapping of S3Object LastModified and Size. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports the new 4.0 client aws/aws-sdk-net#3362
Logged some initial feedback here: aws/aws-sdk-net#3784