Upgrade SDK to 4.0 #316
Draft
Upgrade SDK to 4.0 #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the AWS SDK to version 4.0 and adjusts the code to accommodate new API and language features.
- Updated credentials resolution to use DefaultAWSCredentialsIdentityResolver.
- Revised handling of nullable properties and updated JSON conversion methods.
- Adjusted collection initializers and null checks in file deletion and attribute parsing logic.
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Foundatio.AWS/Storage/S3FileStorage.cs | Updated credentials, fixed nullable LastModified handling, and modified delete request initialization. |
| src/Foundatio.AWS/Queues/SQSQueue.cs | Updated credentials and modified redrive policy creation using JsonObject. |
| src/Foundatio.AWS/Queues/AttributeExtensions.cs | Updated JSON parsing for RedrivePolicy and streamlined TryParse calls. |
| src/Foundatio.AWS/Extensions/Extensions.cs | Updated FileSpec conversion logic to safely handle nullable properties. |
Files not reviewed (1)
- src/Foundatio.AWS/Foundatio.AWS.csproj: Language not supported
| @@ -306,7 +307,7 @@ public async Task<bool> ExistsAsync(string path) | |||
| const int PAGE_SIZE = 100; | |||
|
|
|||
| var listRequest = new ListObjectsV2Request { BucketName = _bucket, Prefix = criteria.Prefix, MaxKeys = PAGE_SIZE }; | |||
| var deleteRequest = new DeleteObjectsRequest { BucketName = _bucket }; | |||
| var deleteRequest = new DeleteObjectsRequest { BucketName = _bucket, Objects = [] }; | |||
There was a problem hiding this comment.
The 'Objects' property of DeleteObjectsRequest likely expects a list (e.g., List), but an empty array literal is used. Please initialize it with new List() to ensure compatibility with subsequent AddRange calls.
Suggested change
| var deleteRequest = new DeleteObjectsRequest { BucketName = _bucket, Objects = [] }; | |
| var deleteRequest = new DeleteObjectsRequest { BucketName = _bucket, Objects = new List<KeyVersion>() }; |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress wanted to see what all was breaking.
Logged some initial feedback here: aws/aws-sdk-net#3784