Draft
Conversation
This was referenced Sep 5, 2024
niemyjski
force-pushed
the
feature/elastic-client
branch
from
f347b85 to
c6be6c7
Compare
This was referenced Sep 16, 2024
Closed
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| { | ||
| string elasticsearchUrl = Environment.GetEnvironmentVariable("ELASTICSEARCH_URL") ?? "http://localhost:9200"; | ||
| var settings = new ConnectionSettings(new Uri(elasticsearchUrl)); | ||
| var settings = new ElasticsearchClientSettings(new Uri(elasticsearchUrl)); |
| var response = elasticResponse as IResponse; | ||
| if (includeDebugInformation && response?.DebugInformation != null) | ||
| sb.AppendLine(response.DebugInformation); | ||
| if (includeDebugInformation && elasticResponse?.DebugInformation != null) |
src/Foundatio.Parsers.ElasticQueries/Extensions/DefaultAggregationNodeExtensions.cs
Fixed
Show fixed
Hide fixed
|
|
||
| if (depth == 0) | ||
| resolvedFieldName += _inferrer.PropertyName(fieldMapping.Name); | ||
| resolvedFieldName += _inferrer.PropertyName(name); |
| resolvedFieldName += _inferrer.PropertyName(name); | ||
| else | ||
| resolvedFieldName += "." + _inferrer.PropertyName(fieldMapping.Name); | ||
| resolvedFieldName += "." + _inferrer.PropertyName(name); |
Updates the Elasticsearch client library to version 9.2.2. This change addresses compatibility issues and incorporates the latest features and fixes available in the updated client. Updates aggregation usages with new client changes.
| var end = context.GetDate("EndDate"); | ||
| bool isValidRange = start.HasValue && start.Value > DateTime.MinValue && end.HasValue && end.Value < DateTime.MaxValue && start.Value <= end.Value; | ||
| var bounds = isValidRange ? new ExtendedBounds<DateMath> { Minimum = start.Value, Maximum = end.Value } : null; | ||
| var bounds = isValidRange ? new ExtendedBounds<DateTime> { Min = start.Value, Max = end.Value } : null; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr drops support the 7.x Nest client (unsupported EOY see elastic/elasticsearch-net#8014 (comment)) and upgrading to the new Elastic.Clients.Elasticsearch client.
Blocking Issues (WIP)
FluentDescriptorDictionaryelastic/elasticsearch-net#8349)