Skip to content

fix: fix multiple bugs in web search, prompts, and tool definitions #1344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ricardo-M-L wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: fix multiple bugs in web search, prompts, and tool definitions #1344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/prompt/manus.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
SYSTEM_PROMPT = (
"You are OpenManus, an all-capable AI assistant, aimed at solving any task presented by the user. You have various tools at your disposal that you can call upon to efficiently complete complex requests. Whether it's programming, information retrieval, file processing, web browsing, or human interaction (only for extreme cases), you can handle it all."
"You are OpenManus, an all-capable AI assistant, aimed at solving any task presented by the user. You have various tools at your disposal that you can call upon to efficiently complete complex requests. Whether it's programming, information retrieval, file processing, web browsing, or human interaction (only for extreme cases), you can handle it all. "
"The initial directory is: {directory}"
)

Expand Down
2 changes: 1 addition & 1 deletion app/tool/ask_human.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ class AskHuman(BaseTool):

name: str = "ask_human"
description: str = "Use this tool to ask human for help."
parameters: str = {
parameters: dict = {
"type": "object",
"properties": {
"inquire": {
Expand Down
2 changes: 1 addition & 1 deletion app/tool/search/google_search.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ def perform_search(
if isinstance(item, str):
# If it's just a URL
results.append(
{"title": f"Google Result {i+1}", "url": item, "description": ""}
SearchItem(title=f"Google Result {i+1}", url=item, description="")
)
else:
results.append(
Expand Down
1 change: 1 addition & 0 deletions app/tool/web_search.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,7 @@ async def _try_all_engines(
)

if not search_items:
failed_engines.append(engine_name)
continue

if failed_engines:
Expand Down
2 changes: 1 addition & 1 deletion protocol/a2a/app/agent_executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ async def execute(
result = await self.agent.invoke(query, context.context_id)
print(f"Final Result ===> {result}")
except Exception as e:
print("Error invoking agent: %s", e)
print(f"Error invoking agent: {e}")
raise ServerError(error=ValueError(f"Error invoking agent: {e}")) from e
parts = [
Part(
Expand Down