fix: add timeout to Bing search request and replace bare except clauses#1355
Open
Ricardo-M-L wants to merge 1 commit intoFoundationAgents:mainfrom
Open
fix: add timeout to Bing search request and replace bare except clauses#1355Ricardo-M-L wants to merge 1 commit intoFoundationAgents:mainfrom
Ricardo-M-L wants to merge 1 commit intoFoundationAgents:mainfrom
Conversation
1. bing_search.py: Add timeout=30 to session.get() to prevent indefinite hang on unresponsive servers. 2. terminal.py: Replace 3 bare `except:` with `except Exception:` in cleanup code to allow KeyboardInterrupt/SystemExit to propagate. 3. sb_shell_tool.py: Same bare except fix in tmux session cleanup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
1. Missing timeout in Bing search (
app/tool/search/bing_search.py)session.get(url=url)has no timeout — a slow or unresponsive Bing server blocks the agent indefinitely. Addedtimeout=30.2. Bare
except:in terminal cleanup (app/sandbox/core/terminal.py)Three bare
except:clauses inclose()catchSystemExitandKeyboardInterrupt, preventing graceful shutdown. Replaced withexcept Exception:.3. Bare
except:in shell tool cleanup (app/tool/sandbox/sb_shell_tool.py)Same issue in tmux session cleanup on error path.