Skip to content

chore: several optimizations#648

Merged
mannaandpoem merged 7 commits intoFoundationAgents:mainfrom
fred913:main
Mar 15, 2025
Merged

chore: several optimizations#648
mannaandpoem merged 7 commits intoFoundationAgents:mainfrom
fred913:main

Conversation

@fred913
Copy link
Copy Markdown
Collaborator

@fred913 fred913 commented Mar 15, 2025

Changes:

  • Add Even Better TOML plugin recommendation and format usage
  • Add .gitignore for config directory, exclude config.yaml runtime config file
    • Consider: exclude all files except the example
  • Configure Isort to be run on save, black to be run on format. That fits the repo pre-commit rules.

Copy link
Copy Markdown
Collaborator Author

@fred913 fred913 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aka. improvement of quality of life for collaborators using VS Code 😂

@a-holm
Copy link
Copy Markdown
Contributor

a-holm commented Mar 15, 2025

These changes are good (I also use VS Code), nice idea. Didn't even know it could automatically run the repo pre-commit rules as I saved. Good job.

@fred913
Copy link
Copy Markdown
Collaborator Author

fred913 commented Mar 15, 2025

@a-holm Thanks for your review! Those changes actually come from the pre-commit configurations.

In the Pre-Commit process, it does things like

  1. trailing whitespace check&fix
  2. EOF line fix
  3. Python file format (black)
  4. isort
  5. flake
  6. YAML check
  7. large file check

What I did is to move the 1-4 steps in real-time while coding.

  1. almost all formatters support removing trailing whitespaces
  2. VS Code allows files.insertFinalNewline to be true, so when you save a file, it adds a new line at the end of file.
  3. Via black extension, VS Code can be configured to use Black formattor during coding.
  4. Same as black, just for isort

That's why i call it QOL improvement lol

@mannaandpoem
Copy link
Copy Markdown
Collaborator

LGTM

@mannaandpoem mannaandpoem merged commit 564a9fd into FoundationAgents:main Mar 15, 2025
1 of 2 checks passed
iHeyTang pushed a commit to iHeyTang/OpenManus that referenced this pull request Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants