Fix very long user IDs #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spraza
previously approved these changes
May 14, 2025
johscheuer
previously approved these changes
May 14, 2025
User ID is used as part of ensemble name, which is limited to be 63 bytes long.
When user ID becomes long, the original logic truncate the ensemble such that
a non-alphanumeric character can be the last one, causing failures in k8s like:
{"reason":"FieldValueInvalid","message":"Invalid value: \"20250514-000408-XXXXX-XXXXXXX-XXXXX-XXXXXXXXXXX-XXXXXX-XXXX-\": a valid label must be an empty string or consist of alphanumeric characters, '-', '_' or '.', and must start and end with an alphanumeric character (e.g. 'MyValue', or 'my_value', or '12345', regex used for validation is '(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])?')","field":"metadata.labels"}]},"code":422}
spraza
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User ID is used as part of ensemble name, which is limited to be 63 bytes long. When user ID becomes long, the original logic truncate the ensemble such that a non-alphanumeric character can be the last one, causing failures in k8s like:
{"reason":"FieldValueInvalid","message":"Invalid value: "20250514-000408-XXXXX-XXXXXXX-XXXXX-XXXXXXXXXXX-XXXXXX-XXXX-": a valid label must be an empty string or consist of alphanumeric characters, '-', '' or '.', and must start and end with an alphanumeric character (e.g. 'MyValue', or 'my_value', or '12345', regex used for validation is '(([A-Za-z0-9][-A-Za-z0-9.]*)?[A-Za-z0-9])?')","field":"metadata.labels"}]},"code":422}