Be more selective around which pods we delete/cleanup. #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add 'if [[ "${job_prefix_from_pod}" =~ ^${AGENT_NAME}-[0-9]+(-[0-9]+)?$ ]]'
check before delete.
As it was, we were emitting the below:
=== Deleting Job joshua-rhel9-job-cleanup ===
+ kubectl delete job joshua-rhel9-job-cleanup -n default
Error from server (NotFound): jobs.batch "joshua-rhel9-job-cleanup" not found
Harmless but noisey.
kakaiu
reviewed
Jun 4, 2025
| echo "=== Deleting Job based on pod status: $job_prefix_from_pod === (AGENT_NAME: ${AGENT_NAME})" | ||
| kubectl delete job "$job_prefix_from_pod" -n "${namespace}" --ignore-not-found=true | ||
| else | ||
| # This case can occur if AGENT_NAME is unusual (e.g., 'foo-bar' and a pod 'foo-bar-baz-TIMESTAMP-...' exists) |
There was a problem hiding this comment.
Why will we have an unusual AGENT_NAME? Is this common?
Thanks!
Contributor
Author
There was a problem hiding this comment.
It should not happen. We have only Joshua-agent and Joshua-rhel9-agent for AGENT_NAME....
kakaiu
approved these changes
Jun 4, 2025
saintstack
pushed a commit
to saintstack/fdb-joshua
that referenced
this pull request
Jun 4, 2025
…xes to agent-scaler.sh script).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 'if [[ "${job_prefix_from_pod}" =~ ^${AGENT_NAME}-[0-9]+(-[0-9]+)?$ ]]' check before delete.
As it was, we were emitting the below:
=== Deleting Job joshua-rhel9-job-cleanup ===
Harmless but noisy.
To test the PR, I ran the patched version beside the current version: the patched version no longer had messages like the above (while it cleaned up finished pods).