Skip to content

Conversation

@johscheuer
Copy link
Member

@johscheuer johscheuer commented Mar 19, 2025

Description

Rewrite the data-loader in go.

Type of change

  • Other

Discussion

Rewrite of the data loader in Golang.

Testing

Ran the tests manually with the new image.

Documentation

Follow-up

@johscheuer johscheuer requested a review from nicmorales9 March 19, 2025 16:49
@foundationdb-ci
Copy link
Contributor

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: ce6dbeb
  • Duration 0:05:24
  • Result: ❌ FAILED
  • Error: Error while executing command: IMG=${REGISTRY}/${OPERATOR_IMAGE} make container-build container-push. Reason: exit status 2
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: bdd528d
  • Duration 3:13:08
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: ab1ec08
  • Duration 3:21:52
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 6da4b0b
  • Duration 2:21:09
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer johscheuer force-pushed the update-data-loader-job branch from 6da4b0b to 8313e41 Compare March 26, 2025 09:28
@foundationdb-ci
Copy link
Contributor

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 8313e41
  • Duration 1:48:38
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 9ac94c1
  • Duration 2:33:26
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Copy link
Contributor

@nicmorales9 nicmorales9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would definitely test the multi-cluster path but otherwise LGTM

@johscheuer johscheuer force-pushed the update-data-loader-job branch from 9ac94c1 to 19bbc19 Compare May 13, 2025 17:28
@foundationdb-ci
Copy link
Contributor

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

  • Commit ID: 19bbc19
  • Duration 1:50:47
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer johscheuer force-pushed the update-data-loader-job branch from 19bbc19 to 1718916 Compare June 25, 2025 15:37
@foundationdb-ci
Copy link
Contributor

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

  • Commit ID: 1718916
  • Duration 2:02:14
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

  • Commit ID: 7618f0d
  • Duration 2:02:06
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer johscheuer force-pushed the update-data-loader-job branch from 7618f0d to bf9db79 Compare December 11, 2025 15:31
Copy link
Member Author

@johscheuer johscheuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed all the other changes and made this a 1:1 rewrite. We can add the other features in the future again.

@foundationdb-ci
Copy link
Contributor

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

  • Commit ID: bf9db79
  • Duration 1:56:09
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer johscheuer closed this Dec 12, 2025
@johscheuer johscheuer reopened this Dec 12, 2025
@johscheuer johscheuer changed the title Rewrite the data-loader in go and allow the data-loader to be modified Rewrite the data-loader in go Dec 12, 2025
@johscheuer johscheuer merged commit 2fb4154 into FoundationDB:main Dec 12, 2025
17 of 25 checks passed
@johscheuer johscheuer deleted the update-data-loader-job branch December 12, 2025 08:37
@foundationdb-ci
Copy link
Contributor

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

  • Commit ID: bf9db79
  • Duration 2:38:58
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants