Skip to content

Conversation

@liamcannon
Copy link
Contributor

dotnet 9 =)

@jupster jupster requested review from Foxlider and jupster July 16, 2025 04:49
@jupster jupster linked an issue Jul 16, 2025 that may be closed by this pull request
@jupster jupster marked this pull request as ready for review July 16, 2025 10:10
Copy link
Collaborator

@jupster jupster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Give it a version Bump then it is good

@Foxlider
Copy link
Owner

Might have to check if we can package bump Json OR switch to dotnet's System.Text.Json
GHSA-5crp-9r3c-p9vr

@Foxlider
Copy link
Owner

ALSO
Might have to make sure that the pipelines can handle the submodule

- Reverts CodeQL analysis to use ubuntu-latest runner due to memory issues.
- Enables fetching submodules in CodeQL analysis workflow to ensure proper analysis.
- Disables fetching submodules in release workflow and sets fetch-depth to 0 for tag history processing.
- Enables Windows targeting and sets publish ready to run options.
@Foxlider Foxlider force-pushed the faster/updatefix branch 2 times, most recently from 275896d to ca91f42 Compare July 16, 2025 13:11
Adds a global.json file to specify the .NET SDK version and rollForward policy.
This ensures consistent builds and development environments by pinning the SDK version.
Sets up a CodeQL analysis workflow to automatically analyze the codebase for potential security vulnerabilities and code quality issues.

The workflow is triggered on push to master, pull requests against master, and manual workflow dispatch.
It performs analysis using the 'csharp' language.

SonarCloud analysis is temporarily disabled and will be auto-analysing the project and the PRs.
@OverlordZorn
Copy link

@Foxlider
Copy link
Owner

Shhhhh~

@OverlordZorn
Copy link

Shhhhh~

🙊

I messed up but is ok
.github\workflows\codeql-analysis.yml = .github\workflows\codeql-analysis.yml
FASTER_Version.xml = FASTER_Version.xml
NuGet.Config = NuGet.Config
.github\workflows\publish.yml = .github\workflows\publish.yml
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WHy removing those from the SLN ?

Copy link
Contributor Author

@liamcannon liamcannon Jul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bro idk, my vs on my desktop fucks with git all the time.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, I put it back :p

@Foxlider Foxlider requested a review from jupster July 16, 2025 14:34
@sonarqubecloud
Copy link

@jupster jupster merged commit b8d8f3c into Foxlider:master Jul 17, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Steam API

4 participants