feat: Re-architect and simplify stacks parsing to support parsed compose project #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add socket-proxy for compose development * add mounts extended compose file for user-specific mounts without modifying devcontainer
* Include socket-proxy for compose parsing support * Makes extending with mounts.yml easier for doing dev with local directories
…data and simplify all stack generation * Remove/rename directory ENVs to be clearer in description * Introduce STACKS_FROM source of truth ENV * Remove rigid monorepo mode, make git stack builder responsible for finding git up parent tree * Use parsed compose project data to supplement stack building (name, compose files)
Owner
Author
|
This refactor drastically simplifies parsing stacks:
services:
komodo-import:
image: foxxmd/komodo-import:pr-3
volumes:
## The top-level folder compose projects on the host live in
##
## * In STACKS_FROM=compose mode this can be any folder as long as all stacks are subfolders at some point
## * In STACKS_FROM=dir mode this is the "parent" folder where all immediate subfolders are compose projects (dockge)
- /home/myUser/myStacks:/filesOnServer
environment:
## Same path as the host folder mounted above
- HOST_DIR=/home/myUser/myStacks
## Komodo Server name to use for generated Stacks
- SERVER_NAME=my-cool-server
## Source of truth for what stacks are generated
##
## * dir => (default) generate from subfolders mounted in /filesOnServer
## * compose => generate from compose projects present on machine (requires DOCKER_HOST+socket-proxy or mounting /var/run/docker.sock)
- STACKS_FROM=compose
- DOCKER_HOST=tcp://socket-proxy:2375
## optional
#- TZ=America/New_York
#- IMAGE_REGISTRY_PROVIDER=
#- IMAGE_REGISTRY_ACCOUNT=
#- AUTO_UPDATE=false
#- POLL_FOR_UPDATE=false
#- KOMODO_ENV_NAME=
#- COMPOSE_FILE_GLOB=
#- ENV_FILE_GLOB=
#- API_KEY=
#- API_SECRET=
restart: no
socket-proxy:
image: lscr.io/linuxserver/socket-proxy:latest
environment:
- CONTAINERS=1
- INFO=1
- POST=0
- PING=1
- VERSION=1
volumes:
- /var/run/docker.sock:/var/run/docker.sock:ro
read_only: true
tmpfs:
- /run |
Contributor
📦 A new release has been made for this pull request.To play around with this PR, pull an image:
Images are available for x86_64 and ARM64.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change