feat(tealfm): Write MusicBrainz IDs for artists#425
Open
owendaprile wants to merge 1 commit intoFoxxMD:masterfrom
Open
feat(tealfm): Write MusicBrainz IDs for artists#425owendaprile wants to merge 1 commit intoFoxxMD:masterfrom
owendaprile wants to merge 1 commit intoFoxxMD:masterfrom
Conversation
✅ Deploy Preview for multi-scrobbler canceled.
|
Owner
|
thanks for the contribution!
The play artist field is something I've been meaning to refactor to avoid this assumption. I think this is correct for all cases at the moment but there's no gaurantee, and album artist parsing from various sources might mess this up. I need to create some test cases for this first, or just do the refactor, to make sure this is safe. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Type of change
Describe your changes
This updates the teal.fm client to also write
artistMbIdalongsideartistNameas described in the lexicon.This assumes that the order of artists in
TrackData.artistsandBrainzMeta.artistare the same, which appears to be the case from the other sources I checked.For plays with empty/unmatched
BrainzMeta.artistitems, nothing will be written.