fix: add Soroban auth secret nonce revocation method - #1185
Open
Oluwasegun6921 wants to merge 3 commits into
Open
fix: add Soroban auth secret nonce revocation method#1185Oluwasegun6921 wants to merge 3 commits into
Oluwasegun6921 wants to merge 3 commits into
Conversation
|
@Oluwasegun6921 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
@Oluwasegun6921 |
Contributor
|
@Oluwasegun6921 |
Contributor
|
@Oluwasegun6921 |
Contributor
|
@Oluwasegun6921 |
Contributor
|
@Oluwasegun6921 |
Author
|
@Fracverse Hi! This PR is open and ready for review — happy to address any feedback. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds a Soroban Auth Secret Nonce Revocation mechanism that enables asset owner accounts to invalidate past off-chain signatures if a secret key is compromised before signatures expire. It implements a
revoke_user_noncesfunction and enforces a minimum nonce threshold during authorization payload validation.Related Issue
Changes
🔐 Nonce Revocation Method
[ADD]
contracts/access-control/src/lib.rsrevoke_user_nonces(env: Env, min_nonce: u64)for asset owner accounts.[MODIFY]
contracts/access-control/src/lib.rsnonce < min_nonce.[ADD]
contracts/access-control/src/test.rsrevoke_user_nonces.Verification Results
revoke_user_nonces(env, min_nonce)for asset owner accountsnonce < min_nonceCloses #1175