feat: Implement and test POST /api/kyc/submit endpoint - #170
Merged
Conversation
ONEONUORA
approved these changes
Feb 24, 2026
ONEONUORA
left a comment
Contributor
There was a problem hiding this comment.
Nice implementation @Olowodarey
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the user-facing KYC submission endpoint (
POST /api/kyc/submit) and introduces a comprehensive integration test suite covering:While the route handler and
KycService::submit_kycmethod were already scaffolded, they lacked test coverage. This PR closes that gap and ensures the endpoint is production-ready and verifiable.What Was Done
1️⃣ Endpoint Verification
Confirmed that:
POST /api/kyc/submitis correctly wired inapp.rsAuthenticatedUserextractorKycService::submit_kyckyc_statustable:The record is inserted (or updated) with:
This guarantees idempotent behavior for repeated submissions.
2️⃣ Integration Test Suite
Added 5 integration tests in:
Key characteristics:
create_appTest Coverage Includes
kyc_statusrow withpendingstatusTechnical Notes
create_appAuthenticatedUserextractor for auth enforcementChecklist
closes #126