Test:Get Plan (Ownership Protection) - #177
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented Ownership Protection task for fetching plans.
Summary of changes:
Backend Service: Added PlanService::get_plan_by_id_any_user to fetch plans regardless of owner.
API Handler: Updated the get_plan handler in app.rs to distinguish between 404 Not Found (nonexistent plan) and 403 Forbidden (not the owner).
Integration Tests: Added a new test suite
ownership_protection_tests.rs
which verifies all scenarios, including invalid UUIDs (400) and authorized/unauthorized access.
All tests passed successfully. Please review the detailed
walkthrough
for more information.
closes #112