Group multi-node junctions in SuggestedLanesPostprocessor#1705
Draft
Karry wants to merge 3 commits intoFramstag:masterfrom
Draft
Group multi-node junctions in SuggestedLanesPostprocessor#1705Karry wants to merge 3 commits intoFramstag:masterfrom
Karry wants to merge 3 commits intoFramstag:masterfrom
Conversation
Complex OSM intersections are modeled as multiple nodes connected by short internal segments that maintain the same lane configuration. The lane suggestion algorithm previously processed each node independently, seeing only a subset of exits and producing wrong lane recommendations. Scan backwards through the route buffer to detect consecutive junction nodes that are close together (<50m) and share the same lane config, then aggregate their exits into a single evaluation. Filter exits pointing back toward the incoming direction to suppress opposite carriageway false positives in grouped junctions. Fixes the Průmyslová/Černokostecká test case.
Owner
|
Is this ready for merge? How was your KI experience? |
Owner
|
@Karry : Ready to merge? |
Collaborator
Author
|
Not yet unfortunately. I found out that situation for some junctions get worse actually. Today, it is easy vibe-code tens of tools, but still you need time for writing prompts and validating the output... :-) I will post some testing tool later when I will have some time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vibe-coded improvement of "suggested lane" heuristics... I am going to test with real word junctions and carefully review it first.
Complex OSM intersections are modeled as multiple nodes connected by short internal segments that maintain the same lane configuration. The lane suggestion algorithm previously processed each node independently, seeing only a subset of exits and producing wrong lane recommendations.
Scan backwards through the route buffer to detect consecutive junction nodes that are close together (<50m) and share the same lane config, then aggregate their exits into a single evaluation. Filter exits pointing back toward the incoming direction to suppress opposite carriageway false positives in grouped junctions.
Fixes the Průmyslová/Černokostecká test case.