fix: add buffer-length check in MeasureBootPeCoff.c#374
Open
orbisai0security wants to merge 1 commit into
Open
fix: add buffer-length check in MeasureBootPeCoff.c#374orbisai0security wants to merge 1 commit into
orbisai0security wants to merge 1 commit into
Conversation
Automated security fix generated by OrbisAI Security
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix critical severity security issue in
tools/mrtool/cgo/MeasureBootPeCoff.c.Vulnerability
V-001tools/mrtool/cgo/MeasureBootPeCoff.c:96Description: The PE/COFF measurement tool performs memcpy operations using sizes derived from PE header fields without adequate bounds checking. At line 96, ReadSize is derived from the PE binary being parsed and used directly in memcpy without validating it against the allocated Buffer size. At line 1233, section headers are copied based on NumberOfSections from the PE header without validating this count against the allocated array size. A crafted PE/COFF binary with manipulated header fields can trigger heap buffer overflows, potentially allowing arbitrary code execution in the measurement tool context.
Evidence
Exploitation scenario: An attacker who can supply a crafted PE/COFF binary file to the mrtool (via local filesystem access or through a service that invokes measurement) pro...
Scanner confirmation: multi_agent_ai rule
V-001flagged this pattern.Production code: This file is in the production codebase, not test-only code.
Threat Model Context
This is a Go service - vulnerabilities in HTTP handlers are remotely exploitable.
Changes
tools/mrtool/cgo/MeasureBootPeCoff.cVerification
Automated security fix by OrbisAI Security