Skip to content

Tagging typically depends on DFG and also on EOG#2778

Open
KuechA wants to merge 1 commit into
mainfrom
ak/improved-pass-dependencies
Open

Tagging typically depends on DFG and also on EOG#2778
KuechA wants to merge 1 commit into
mainfrom
ak/improved-pass-dependencies

Conversation

@KuechA

@KuechA KuechA commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@KuechA KuechA requested a review from maximiliankaul as a code owner June 2, 2026 14:25
@KuechA KuechA requested review from konradweiss and oxisto June 2, 2026 14:25
@codecov

codecov Bot commented Jun 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.27%. Comparing base (81f7971) to head (c432a54).
⚠️ Report is 10 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
Files with missing lines Coverage Δ
...hofer/aisec/cpg/passes/concepts/TagOverlaysPass.kt 80.00% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DependsOn(ControlFlowSensitiveDFGPass::class, true)
@DependsOn(PointsToPass::class, true)
@DependsOn(DFGPass::class, true)
@DependsOn(EvaluationOrderGraphPass::class)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SymbolResolver should already depend on EOG, so does CF-DFG and/or PointsToPass. Why is this even necessary?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For CF-DFG and PointsToPass: These are optional, so if we do not register them, it means that only the SymbolResolver is left. I saw this pass being executed before the DFG Pass which was strange. And I prefer to have such dependencies/assumptions written down explicitly. But I agree, the EOG may not be strictly necessary here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants