Tagging typically depends on DFG and also on EOG#2778
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| @DependsOn(ControlFlowSensitiveDFGPass::class, true) | ||
| @DependsOn(PointsToPass::class, true) | ||
| @DependsOn(DFGPass::class, true) | ||
| @DependsOn(EvaluationOrderGraphPass::class) |
There was a problem hiding this comment.
SymbolResolver should already depend on EOG, so does CF-DFG and/or PointsToPass. Why is this even necessary?
There was a problem hiding this comment.
For CF-DFG and PointsToPass: These are optional, so if we do not register them, it means that only the SymbolResolver is left. I saw this pass being executed before the DFG Pass which was strange. And I prefer to have such dependencies/assumptions written down explicitly. But I agree, the EOG may not be strictly necessary here.
No description provided.