PTP: Improve handling of global structs#2799
Open
morbitzer wants to merge 20 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
morbitzer
requested review from
KuechA,
fwendland,
konradweiss,
oxisto and
peckto
as code owners
konradweiss
approved these changes
Jun 30, 2026
| // Since we already have the argVal, AKA the memoryAddress | ||
| // of the argDerefVal, we simply fetch the last write for the | ||
| // argVal from the declarationState and add the properties | ||
| // TODO: what if argVal is global? |
Collaborator
There was a problem hiding this comment.
Is this question one that we can address in this PR, is not relevant anymore or is here as a reminder for the future?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some occasions, the PtP was not able to correctly draw the prevDFG of PMVs. This should be fixed with this PR.