Skip to content

PtP: Add DFG edges to PMVs of recursive functions#2801

Open
morbitzer wants to merge 4 commits into
mainfrom
mm/ptp-fix-recursive-pmvs
Open

PtP: Add DFG edges to PMVs of recursive functions#2801
morbitzer wants to merge 4 commits into
mainfrom
mm/ptp-fix-recursive-pmvs

Conversation

@morbitzer

Copy link
Copy Markdown
Collaborator

So far, the PtP failed to draw prevDFG edges for the PMVs of functions that are recursively called. This should work now.

@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 69.56522% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.18%. Comparing base (aeb76d2) to head (151dcb0).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...lin/de/fraunhofer/aisec/cpg/passes/PointsToPass.kt 69.56% 3 Missing and 4 partials ⚠️

❌ Your patch check has failed because the patch coverage (69.56%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
Files with missing lines Coverage Δ
...lin/de/fraunhofer/aisec/cpg/passes/PointsToPass.kt 84.98% <69.56%> (+0.17%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@morbitzer morbitzer marked this pull request as ready for review June 22, 2026 08:56

@konradweiss konradweiss left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed lines in in the codecov report are the logging calls that are not enabled, which is not relevant functionality to test. Are they necessary though? From the content of the message I think we don't need it in production and therefore can remove both and make codecov happy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants