-
Notifications
You must be signed in to change notification settings - Fork 46
1169 datademosfh cbio intro content refresh needed #1185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1169 datademosfh cbio intro content refresh needed #1185
Conversation
deleting old version of upload instructions.
New upload instructions
Adding a data demo page for instructions on how to test if a user has the right access to the fh-dasl-cbio S3 bucket
Adding header
Adding preliminary content
…3_bucket.md changing file prefix for consistency
Creating a demo for how to prepare files for cBioPortal
Creating a demo for how to use cbioportal with specific examples
Creating demo to show how to upload data in fh-dasl-cbio S3 bucket
Draft of pathway article for uploading a study into the Fred Hutch instance of cBioPortal
Version 1 of the updated docs!
Outline of content for usage examples
Draft version
Adding new version of cbio_01_oncoprint_kras_different_studies.png
Updating figure cbio_02_KRAS_lollipop.png
Updating cbio_04_KRAS_clinical_covariates.png
Updating cbio_05_KRAS_clinical_mut.png
Horizontal version of cbio_05_KRAS_clinical_mut
Creating a new data demo for examples of using cBioPortal
Updated cbio_test_access_to_cbio_s3_bucket.md
Updating content on how to prepare files for cBioPortal as a demo
Content update for Uploading your study into `fh-dasl-cbio` S3 bucket
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really like the new structure. I think it will be super helpful for new users
Hopefully all the links work as expected! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sadly haven't finished reviewing everything, but wanted to provide feedback before the weekend. Two main points:
- For hyperlinks, if you add the
.md
file extension to the hyperlink, it borks the link unfortunately, so make sure to get rid of those. - For the accordion dropdowns, I think you'll need to use old school HTML rather than Markdown to preserve formatting. Sadly they look weird when I built the site locally.
Will finish looking through the _datademos
updates soon!
Adding all changes suggested by @tefirman Co-authored-by: Taylor Firman <[email protected]>
Removed accordian style drop downs.
Adding AWS CLI configuration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome, really like how you split up the different topics into separate articles! Just found some broken links because of the article re-org, but definitely approve once those are fixed. Thanks @sitapriyamoorthi !
Co-authored-by: Taylor Firman <[email protected]>
Co-authored-by: Taylor Firman <[email protected]>
Co-authored-by: Taylor Firman <[email protected]>
Co-authored-by: Taylor Firman <[email protected]>
Co-authored-by: Taylor Firman <[email protected]>
Co-authored-by: Taylor Firman <[email protected]>
Co-authored-by: Taylor Firman <[email protected]>
Co-authored-by: Taylor Firman <[email protected]>
Co-authored-by: Taylor Firman <[email protected]>
@tefirman only one comment on one of your comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @sitapriyamoorthi ! Excited for the docs upgrade, really appreciate your hard work on this!
This is a big re-write of cBioPortal content. It involves the following changes: