Enhance and fix translation on JSON api and AJAX #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S1ngS1ng
suggested changes
Aug 1, 2017
| @@ -336,7 +336,7 @@ | |||
| "</div>" | |||
| ], | |||
| "tests": [ | |||
| "assert(code.match(/filter/gi), 'message: You should be making use of the .filter method.');" | |||
| "assert(code.match(/filter/gi), 'message: 你应该使用 .filter 这个方法。');" | |||
There was a problem hiding this comment.
Might wanna consider onsider <code>.filter</code>?
| "description": [ | ||
| "我们还可以通过浏览器<code>navigator</code>获得我们当前所在的位置<code>geolocation</code>。", | ||
| "位置的信息包括经度<code>longitude</code>和纬度<code>latitude</code>。", | ||
| "在浏览器中还有一个很棒的功能就是我们还可以通过<code>navigator</code>来获得我们当前所在的地理位置<code>geolocation</code>。", |
There was a problem hiding this comment.
还有一件很棒的事情，我们可以获取用户的当前位置。每个浏览器都有自带的 Navigator 接口供我们调用。
There was a problem hiding this comment.
昨晚我就想了有点怪，不过感觉怎么感觉还是很绕口233 不过再改改吧。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
Fix Issue: #346
Enhance and fix translation on challenge JSON api and AJAX.