Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test failure #356

Merged
merged 1 commit into from
Aug 3, 2017
Merged

Fix test failure #356

merged 1 commit into from
Aug 3, 2017

Conversation

S1ngS1ng
Copy link
Contributor

@S1ngS1ng S1ngS1ng commented Aug 3, 2017

Related PR: #352 #248

In this PR

  • Fix assert.isNotArray error
  • As described, update to use assert.isUndefined

Screenshot after change

image

wudifeixue
wudifeixue approved these changes Aug 3, 2017
View reviewed changes
Copy link
Contributor

@wudifeixue wudifeixue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

@wudifeixue wudifeixue merged commit e9e074c into FreeCodeCampChina:dev Aug 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wudifeixue wudifeixue wudifeixue approved these changes

Assignees

@wudifeixue wudifeixue

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@S1ngS1ng @wudifeixue