Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation enhancement for challenge Exact Change #374

Conversation

S1ngS1ng
Copy link
Contributor

Issue ref: #368

In this PR:

  • Enhancement of translation. As per discussion in the issue, add details of cid array

Copy link
Contributor

@wudifeixue wudifeixue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are pretty good so far, though please translate the comment example as well either in the comments or in the description. The name penny, nickel, dime, and quarter is really confusing for most people in China.

@@ -177,7 +177,8 @@
"description": [
"设计一个收银机找零函数 <code>checkCashRegister()</code>,它接收三个参数,分别是购买总价 (<code>price</code>)、付款金额 (<code>cash</code>) 和收银机中可用的零钱 (<code>cid</code>)。",
"<code>cid</code> 是一个二维数组,存着当前可用的找零。每个子数组中的第一个元素代表币种,第二个元素代表这个币种的可用总额。比如,<code>[\"FIVE\", 20.00]</code> 表示五元纸币的可用总额是 <code>20</code>,也就是有四张五元纸币。",
"当收银机中的钱不够找零时返回字符串 <code>\"Insufficient Funds\"</code>. 如果正好则返回字符串 <code>\"Closed\"</code>。",
"其中,<code>\"PENNY\"</code> 表示一分 (0.01),<code>\"NICKLE\"</code> 表示五分 (0.05),<code>\"DIME\"</code> 表示一角 (0.1),<code>\"QUARTER\"</code> 表示两毛五 (0.25)。<code>\"ONE\"</code> 表示一元,<code>\"FIVE\"</code> 表示五元,其余的以此类推。",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wudifeixue I'd rather leave it in description 😂

@@ -187,7 +188,7 @@
" return change;",
"}",
"",
"// Example cash-in-drawer array:",
"// cid 参数示例:",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wudifeixue Good enough?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup exactly what I want to know

@wudifeixue wudifeixue merged commit d1ccf6b into FreeCodeCampChina:dev Aug 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants