Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #377

Closed
wants to merge 1 commit into from
Closed

Update README.md #377

wants to merge 1 commit into from

Conversation

zhuangyin8
Copy link

@zhuangyin8 zhuangyin8 commented Aug 24, 2017

精简文字描述

FreeCodeCamp Pull Request template

Please, go through these steps before you submit a PR.

  1. Make sure that your PR is not a duplicate.
  2. If not, then make sure that:

2.1. You have done your changes in a separate branch. Branches MUST have descriptive names that start with either the fix/ or feature/ prefixes. Good examples are: fix/signin-issue or feature/issue-templates.

2.2. You have a descriptive commit message with a short title (first line).

2.3. You have only one commit (if not, squash them into one commit).

2.4. npm test doesn't throw any error. If it does, fix them first and amend your commit (git commit --amend).

  1. After these steps, you're ready to open a pull request.

3.1. Your pull request MUST NOT target the master branch on FreeCodeCamp's repository. You probably want to target staging instead.

3.2. Give a descriptive title to your PR.

3.3. Provide a description of your changes.

3.4. Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.

PLEASE REMOVE THIS TEMPLATE BEFORE SUBMITTING

@@ -11,7 +11,7 @@
## freecodecamp是什么?
freecodecamp 是一个自由的开源编程社区,它致力于抹平教育差距,

让像你我一样的平凡人也能享受到花费巨资才可能享受到的优质教育
让像你我一样的平凡人不用花费巨资也能享受到的优质教育
Copy link
Contributor

@S1ngS1ng S1ngS1ng Aug 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well looks like we have to rework on the README.md file soon. And to be honest I don't see the meaning of this one line of change. It feels weird either way.

@S1ngS1ng
Copy link
Contributor

@zhuangyin8 先谢谢你的 PR。我们决定还是重写一下 README 吧。

顺便,其实 PR template 也得更新一下,我开个 issue 好了。 @wudifeixue

@S1ngS1ng S1ngS1ng closed this Aug 24, 2017
@S1ngS1ng S1ngS1ng mentioned this pull request Aug 24, 2017
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants