Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the content of README.md. #392

Merged
merged 1 commit into from
Sep 21, 2017
Merged

Update the content of README.md. #392

merged 1 commit into from
Sep 21, 2017

Conversation

Becavalier
Copy link
Contributor

FreeCodeCamp Pull Request template

Please, go through these steps before you submit a PR.

  1. Make sure that your PR is not a duplicate.
  2. If not, then make sure that:

2.1. You have done your changes in a separate branch. Branches MUST have descriptive names that start with either the fix/ or feature/ prefixes. Good examples are: fix/signin-issue or feature/issue-templates.

2.2. You have a descriptive commit message with a short title (first line).

2.3. You have only one commit (if not, squash them into one commit).

2.4. npm test doesn't throw any error. If it does, fix them first and amend your commit (git commit --amend).

  1. After these steps, you're ready to open a pull request.

3.1. Your pull request MUST NOT target the master branch on FreeCodeCamp's repository. You probably want to target staging instead.

3.2. Give a descriptive title to your PR.

3.3. Provide a description of your changes.

3.4. Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.

PLEASE REMOVE THIS TEMPLATE BEFORE SUBMITTING

@Becavalier Becavalier merged commit 28dd56b into dev Sep 21, 2017
@Becavalier Becavalier deleted the Becavalier-patch-readme branch September 21, 2017 04:15
@wudifeixue
Copy link
Contributor

Hi @Becavalier, thank you for your contribution on the project.
I know that we can have a lot of improvement on the README file, but removing everything we had and change everything into English is probably not the right way of doing it.

Since the goal behind this is to translate the whole project into Chinese, and host the whole site in China for easier access and faster speed.

I think we should keep this README in Chinese so people can understand what is going on when they land on this repository. It does get a lot of views daily and we are trying to be friendly here. There are also things that keep tracks of the issues and pull request each week that was removed when it was pretty helpful.

Also I would suggest that if you could please review the changes with the team like we do right now so we don't get a surprise change all a sudden. And please review the contributor guide before submit the changes so we can have everything more organized.

@Becavalier
Copy link
Contributor Author

@wudifeixue Sorry for that. I will pay attention next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants