Change required description on Safari #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S1ngS1ng
suggested changes
May 18, 2018
| @@ -1337,7 +1337,7 @@ | |||
| "例如，如果你想把一个文本输入字段设置为必填项，在你的<code>input</code>元素中加上<code>required</code>属性就可以了，你可以使用：<br><code><input type=\"text\" required></code>", | |||
| "任务：给你的输入框添加<code>required</code>属性，这样用户不填写输入框就无法提交表单。", | |||
| "试试输入框不填写任何文本，然后点击Submit提交表单，看看浏览器如何提示你该字段为必填项。", | |||
| "注意：<code>required</code>属性在Safari浏览器中不起作用，请用其他浏览器来学习，推荐使用Chrome。" | |||
| "注意：<code>required</code>属性在Safari浏览器10.1以下不起作用（2017年3月27以前)，请更更新Safari或者使用其他浏览器来学习，推荐使用Chrome。" | |||
There was a problem hiding this comment.
Also, please unify the symbols (parenthesis here) to EITHER full-width OR half-width. Mix & match won't be a good idea 😂
There was a problem hiding this comment.
哈哈好尴尬呀居然打错了字，那我括号也改一改好了
wudifeixue
force-pushed
the
fix/safari-compatibility-description
branch
from
b91d045 to
d14c6be
Compare
|
Updated now |
S1ngS1ng
approved these changes
May 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
Fixes #447