Juzhiyuan #519
Merged
Juzhiyuan #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juzhiyuan
commented
May 23, 2018
•
juzhiyuan
commented
- 首页添加了 概述
- 首页添加了 焦点图
- 首页添加了 介绍
…decamp.cn into feature/cn-site
This reverts commit 6f818a7.
|
@wudifeixue Either we update it EVERY SINGLE YEAR, or it's time to remove this challenge 🤦♂️ |
|
I just modified two files: index.html & index.css |
|
@juzhiyuan 我这里获取不到你的改动。你有没有 |
|
@S1ngS1ng 有的，并且提交PR了。但是我没有点击Merge，这个事情应该由专人负责的吧。 |
|
|
S1ngS1ng
suggested changes
May 24, 2018
| <a href="#" class="btn">点击进入 > ></a> | ||
| </div> | ||
| <div class="right"> | ||
| <img src="https://staticfile.shaoyaoju.org/20180523/地图2.png" alt=""> |
There was a problem hiding this comment.
这几个图，后续会换成图标 + 文字的形式吧？现在看着很模糊。
public/index.html
Outdated
| </body> | ||
|
|
||
| </html> | ||
| No newline at end of file |
There was a problem hiding this comment.
感觉这一行像是 lint tool 加上的。删掉换成空行就好了
|
|
||
| <body> | ||
| <div id="root"> | ||
| <header>顶部菜单栏</header> |
There was a problem hiding this comment.
这个，还有 “底部区域”，“课程大纲” 那些都是暂时放在这儿占位的吧？
| <img src="https://staticfile.shaoyaoju.org/20180523/%E7%BC%96%E7%A8%8B%E7%95%8C%E9%9D%A22.png" alt=""> | ||
| </div> | ||
| </div> | ||
| <div class="swiper-slide"> |
|
@S1ngS1ng 航哥说不用管移动端；最后一行是 @chj-damon 写框架的时候留在上面的；图像会更换掉的；课程大纲、底部区域等由其他人负责。 |
|
@juzhiyuan 好的 👍 |
S1ngS1ng
approved these changes
May 24, 2018
|
@S1ngS1ng I think we should just remove the Friendly Date Challenge, first, it's not friendly at all, second, the English one has already removed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.