Fix arrow keys not moving units (secondary accelerators never bound) - #164
Open
KevinGriffin-new wants to merge 1 commit into
Open
Fix arrow keys not moving units (secondary accelerators never bound)#164KevinGriffin-new wants to merge 1 commit into
KevinGriffin-new wants to merge 1 commit into
Conversation
Canvas only installs input-map bindings for actions with isCanvasKeyBinding(). The secondary MoveAction constructor — carrying the moveAction.<D>.secondary accelerators (UP/DOWN/LEFT/RIGHT, HOME/END, PGUP/PGDN) — never set the flag, so arrow-key movement was dead on every platform; numpad-less laptops had no keyboard movement at all. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The secondary MoveAction constructor never calls setCanvasKeyBinding(true), so the arrow/Home/End/PgUp/PgDn accelerators from FreeColMessages.properties are never installed in the Canvas input map. Numpad works, arrows do nothing. Found on a laptop with no numpad, where there is currently no keyboard movement at all. One line.