Skip to content

Lower tolerance in BAMG to avoid misidentification of overlapping edges#397

Open
prj- wants to merge 1 commit into
developfrom
jolivet/fix-misidentification
Open

Lower tolerance in BAMG to avoid misidentification of overlapping edges#397
prj- wants to merge 1 commit into
developfrom
jolivet/fix-misidentification

Conversation

@prj-
Copy link
Copy Markdown
Member

@prj- prj- commented May 14, 2026

Fix #319

@cmdoug
Copy link
Copy Markdown
Contributor

cmdoug commented May 14, 2026

Here is a test case. See the chevalier_etal_2024 example.

@prj-
Copy link
Copy Markdown
Member Author

prj- commented May 14, 2026

Here is a test case. See the chevalier_etal_2024 example.

On my end, this test case is failing with:

$ FreeFem++-mpi -v 0 importgmsh.md -gmshdir examples/chevalier_etal_2024 -dir $workdir -mi nozzle_lg.geo
  Loading 'nozzle_lg.geo' in 'examples/chevalier_etal_2024/'.
  Calling GMSH to build .msh file from .geo file.
  current line = 29 mpirank 0 / 1
Assertion fail : (area > 0)
	line :303, in file ./include/fem.hpp
Assertion fail : (area > 0)
	line :303, in file ./include/fem.hpp
 err code 6 ,  mpirank 0

But that's unrelated to BAMG (and the present PR), isn't it?

@cmdoug
Copy link
Copy Markdown
Contributor

cmdoug commented May 14, 2026

Sorry about that, tried to rush something to you. I am heading out on vacation for the next week, but will follow up later this month when I have time to look more closely.

@prj-
Copy link
Copy Markdown
Member Author

prj- commented May 30, 2026

Any update on this, @cmdoug?

@cmdoug
Copy link
Copy Markdown
Contributor

cmdoug commented May 30, 2026

Sorry, not yet. Will get to it this week.

@cmdoug
Copy link
Copy Markdown
Contributor

cmdoug commented Jun 1, 2026

@prj- Sorry for that. I just pushed a fix get past that issue. Seems like this addresses the issue with BAMG, but there is also bug in mortar construction error that will be problematic without an adjustment to some tolerances in fem.cpp as well.

cmdoug added a commit to cmdoug/ff-bifbox that referenced this pull request Jun 3, 2026
cmdoug added a commit to cmdoug/ff-bifbox that referenced this pull request Jun 3, 2026
cmdoug added a commit to cmdoug/ff-bifbox that referenced this pull request Jun 3, 2026
cmdoug added a commit to cmdoug/ff-bifbox that referenced this pull request Jun 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants