Skip to content

Conversation

@matsimon
Copy link
Contributor

@matsimon matsimon commented May 20, 2025

Why the change?

Thoughts based on the systemd version shipped with Debian and RHEL distributions:

  • For Debian-based distributions: Debian 10 already shipped with systemd 241 and is past its long term support, Ubuntu 18.04 LTS shipped with 239 and is also pasts is regular support (only paid support options) so for future releases of FreeRADIUS we should be pretty safe.
  • For EL-based distributions: Considering that RHEL 7 has been out of regular support and that RHEL 8 ships with systemd 239 this change should be safe to.

MemoryMax has been introduced with systemd 231
MemoryLimit has been marked deprecated with systemd 252
@matsimon
Copy link
Contributor Author

This avoids a warning like this one (on Debian 12, using systemd 231)

# systemd-analyze verify /lib/systemd/system/freeradius.service
/lib/systemd/system/freeradius.service:23: Unit uses MemoryLimit=; please use MemoryMax= instead. Support for MemoryLimit= will be removed soon.```

MemoryMax has been introduced with systemd 231 
and MemoryLimit has been marked deprecated with systemd 252.

EL 7 is past its regular support cycle for some time now and 
EL 8 already ships with systemd 239. Thus it should be safe to 
switch to this more modern option for a future release.
@matsimon matsimon changed the title [master] Debian systemd: MemoryLimit -> MemoryMax [master] Debian/RedHat systemd: MemoryLimit -> MemoryMax May 20, 2025
@arr2036
Copy link
Member

arr2036 commented May 20, 2025

Is there any change in behaviour? Or the systemd guys just like renaming things to keep people on their toes?

@mcnewton
Copy link
Member

As well as potential change of behaviour, this also needs checking that it doesn't break any of the older Debian-based distros as they are all built using the same source.

@matsimon
Copy link
Contributor Author

matsimon commented May 20, 2025

@arr2036: It seems to be related to this info in the v252 release of systemd and them dropping cgroupsv1 at some point as described in the "history" section of systemd.resouce-control(5). Also the NEWS file mentions that they plan on dropping it completely with v258.

Considering that (likely) until 4.x gets released, very old distributions based of Debian or RHEL are likely long gone, but for 3.2 it might be worth to do some more checking.

@mcnewton : For what I can see on Debian 12, it's pretty much a drop-in replacement, but I agree with you, that it needs proper checking. There is one other example I found from a package from Red Hat where they updated it for RHEL 9 in redhat-cloud-client-configuration (RHEL-17009).

How distributions using the InkBridge repositories might be affected

InkBridge Networks builds FreeRADIUS packages for RHEL- and Debian-based distributions from this repository, but "only" for the 3.0 & 3.2 releases, not for master or the upcoming 4.x version so these shouldn't be affected IMO. (BTW: Thank you for this service!)

Debian-based distributions

  • The oldest Debian builds are for version 9 / stretch, It shipped with systemd 232 (systemd_232*deb9*.deb).
    No new packages have been built since 2022 for 3.0 and 2023 for 3.2
  • The oldest Ubuntu builds are for version 18.04 / bionic, it shipped with systemd 237.
    No new packages have been built since 2022 for 3.0 and 2023 for 3.2

(RH)EL-based distributions

  • Rocky 8 is likely not affected, it shipped with systemd 239
  • The oldest RHEL-based/-derived distribution is CentOS 7, it shipped with systemd 219.
    New packages have been built in 2025 so this one would be affected by a backport to the 3.2 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants