Fix incorrect error checking of prvCreateIdleTasks #1158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In environments that do not support static allocation (configSUPPORT_STATIC_ALLOCATION == 0), at prvCreateIdleTasks(), call xCreateTask() and compare its return value to pdFAIL to check whether xCreateTask() failed. However, xCreateTask() returns errCOULD_NOT_ALLOCATE_REQUIRED_MEMORY as the error value, so the result of this comparison is always false. This commit fixes this problem by changing the return value comparison to pdPASS instead of pdFAIL.
|
kar-rahul-aws
approved these changes
Oct 16, 2024
aggarg
approved these changes
Oct 16, 2024
moninom1
pushed a commit
to moninom1/FreeRTOS-Kernel
that referenced
this pull request
Sep 30, 2025
* Fix vTaskDelete SMP unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix incorrect error checking of prvCreateIdleTasks
Description
In environments that do not support static allocation (
configSUPPORT_STATIC_ALLOCATION == 0), atprvCreateIdleTasks(), it callsxCreateTask()and compares its return value topdFAIL(0) to check whetherxCreateTask()failed. However,xCreateTask()returnserrCOULD_NOT_ALLOCATE_REQUIRED_MEMORY(-1) as the error value, so the result of this comparison is always false.This MR fixes this problem by changing the return value comparison to
!= pdPASSinstead of== pdFAIL.Test Steps
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.