Remove settings page as bookmarkable, remove unnecessary async & null access operators

Author: kommunarr

src/renderer/App.js

@@ -194,7 +194,7 @@ export default defineComponent({
       this.grabAllProfiles(this.$t('Profile.All Channels')).then(async () => {
         this.grabHistory()
         this.grabAllPlaylists()
-        this.grabPageBookmarks().then(async () => {
+        this.grabPageBookmarks().then(() => {
           this.pageBookmarksAvailable = true
         })
         this.grabAllSubscriptions()

src/renderer/components/ft-input/ft-input.js

@@ -85,7 +85,7 @@ export default defineComponent({
         isPointerInList: false,
         keyboardSelectedOptionIndex: -1,
       },
-      visibleDataList: this.dataList?.slice(0, MAX_VISIBLE_LIST_ITEMS),
+      visibleDataList: this.dataList.slice(0, MAX_VISIBLE_LIST_ITEMS),
       // This button should be invisible on app start
       // As the text input box should be empty
       clearTextButtonExisting: false,
@@ -310,13 +310,13 @@ export default defineComponent({
       this.searchState.selectedOption = -1
       this.searchState.keyboardSelectedOptionIndex = -1
       if (this.inputData === '') {
-        this.visibleDataList = this.dataList?.slice(0, MAX_VISIBLE_LIST_ITEMS)
+        this.visibleDataList = this.dataList.slice(0, MAX_VISIBLE_LIST_ITEMS)
         return
       }
       // get list of items that match input
       const lowerCaseInputData = this.inputData.toLowerCase()
 
-      this.visibleDataList = this.dataList?.slice(0, MAX_VISIBLE_LIST_ITEMS).filter(x => {
+      this.visibleDataList = this.dataList.slice(0, MAX_VISIBLE_LIST_ITEMS).filter(x => {
         if (x.name) {
           return x.name.toLowerCase().indexOf(lowerCaseInputData) !== -1
         }

src/renderer/components/page-bookmark-prompt/page-bookmark-prompt.js

@@ -3,7 +3,7 @@ import { mapActions } from 'vuex'
 import FtFlexBox from '../ft-flex-box/ft-flex-box.vue'
 import FtPrompt from '../ft-prompt/ft-prompt.vue'
 import FtButton from '../ft-button/ft-button.vue'
-import FtInput from '../../components/ft-input/ft-input.vue'
+import FtInput from '../ft-input/ft-input.vue'
 import packageDetails from '../../../../package.json'
 import { showToast } from '../../helpers/utils'
 

src/renderer/components/top-nav/top-nav.js

@@ -54,7 +54,6 @@ export default defineComponent({
         'Watch',
         'Hashtag',
         'Post',
-        'Settings' // for linkable settings sections
       ],
       lastSuggestionQuery: ''
     }