Skip to content

Add local api support for viewing individual community posts + comments #6491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ChunkyProgrammer wants to merge 18 commits into from
Closed

Add local api support for viewing individual community posts + comments #6491

ChunkyProgrammer wants to merge 18 commits into from

Conversation

@ChunkyProgrammer
Copy link
Member

@ChunkyProgrammer ChunkyProgrammer commented Dec 31, 2024

Add local api support for viewing community posts

Pull Request Type

  • Feature Implementation

Related issue

closes #3253

Description

This PR also adds support for viewing community posts + comments to the local API

Testing

  • set local api as primary api
  • disable invidious
  • go to mr beast channel
  • go to community tab
  • click on the link to view one of the posts
  • load comments
  • load comment replies
  • load more comments

See tests here: #5589

Desktop

  • OS: Fedora Linux
  • OS Version: 41
  • FreeTube version: latest nightly

@ChunkyProgrammer ChunkyProgrammer mentioned this pull request Dec 31, 2024
Merged
absidue
absidue reviewed Dec 31, 2024
View reviewed changes
Copy link
Member

@absidue absidue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't need to be done just yet as this PR is still a draft, but it would be good to remove the now unused "posts are only supported by invidious" string once this is ready for review.

@ChunkyProgrammer ChunkyProgrammer force-pushed the add-local-api-support-for-viewing-community-posts branch from 134a6e6 to 22911ff Compare December 31, 2024 23:04
@ChunkyProgrammer ChunkyProgrammer force-pushed the add-local-api-support-for-viewing-community-posts branch from 22911ff to a85ba81 Compare January 9, 2025 16:30
@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Jan 11, 2025

Upstream just merged🎉

@absidue absidue mentioned this pull request Jan 21, 2025
Merged
@ChunkyProgrammer ChunkyProgrammer force-pushed the add-local-api-support-for-viewing-community-posts branch from a85ba81 to 3ad4396 Compare January 21, 2025 13:20
@ChunkyProgrammer ChunkyProgrammer marked this pull request as ready for review January 21, 2025 13:23
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) January 21, 2025 13:24
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jan 21, 2025
@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Jan 21, 2025

Error:

VirtualBoxVM_2gUbmdP7GZ.mp4

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Jan 21, 2025
@ChunkyProgrammer ChunkyProgrammer marked this pull request as draft January 22, 2025 13:34
auto-merge was automatically disabled January 22, 2025 13:34

Pull request was converted to draft

@ChunkyProgrammer
Copy link
Member Author

ChunkyProgrammer commented Jan 22, 2025

Error:
VirtualBoxVM_2gUbmdP7GZ.mp4

Hmm, weirdly I'm only getting that error on that specific post

absidue
absidue reviewed Jan 25, 2025
View reviewed changes
Copy link
Member

@absidue absidue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've submitted a PR upstream to fix the problem LuanRT/YouTube.js#882

The post params were only being encoded to base64 not URL safe base64, so for that post it contained a / which should have been an _, which made YouTube return the channel home tab.

absidue
absidue reviewed Jan 25, 2025
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@ChunkyProgrammer ChunkyProgrammer force-pushed the add-local-api-support-for-viewing-community-posts branch from 8f33321 to 165f6e0 Compare January 27, 2025 03:47
@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2025

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions
Copy link
Contributor

github-actions bot commented Jun 26, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2025

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 13, 2025

Conflicts have been resolved. A maintainer will review the pull request shortly.

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Jul 18, 2025

relies on #7701

@ChunkyProgrammer ChunkyProgrammer added PR: waiting for review For PRs that are complete, tested, and ready for review and removed PR: WIP PR/Issue: dependent PR: blocked labels Jul 19, 2025
efb4f5ff-1298-471a-8973-3d47447115dc
efb4f5ff-1298-471a-8973-3d47447115dc requested changes Jul 20, 2025
View reviewed changes
Copy link
Member

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im getting some errors

VirtualBoxVM_LkiAvQptn8.mp4
VirtualBoxVM_IFtZ6BTo2V.mp4

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Jul 20, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 21, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@ChunkyProgrammer
Copy link
Member Author

ChunkyProgrammer commented Jul 22, 2025

Going to close and reopen this PR without the locale file changes. Seems like weird white space changes are happening

auto-merge was automatically disabled July 22, 2025 21:15

Pull request was closed

@ChunkyProgrammer ChunkyProgrammer mentioned this pull request Jul 22, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc requested changes

@PikachuEXE PikachuEXE Awaiting requested review from PikachuEXE

@kommunarr kommunarr Awaiting requested review from kommunarr

@absidue absidue Awaiting requested review from absidue

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature Request]: View post on community tab

4 participants

@ChunkyProgrammer @efb4f5ff-1298-471a-8973-3d47447115dc @absidue @PikachuEXE