Skip to content

Fix scroll to seek/change volume/playback rate changing too fast with touchpad #6666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
FreeTubeBot merged 3 commits into from
Jul 28, 2025
Merged

Fix scroll to seek/change volume/playback rate changing too fast with touchpad #6666

FreeTubeBot merged 3 commits into from
Jul 28, 2025

Conversation

@PikachuEXE
Copy link
Collaborator

@PikachuEXE PikachuEXE commented Jan 29, 2025 •
edited
Loading

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

Closes #6539

Description

wheel triggered N times more than mouse wheel with smaller delta values to have smooth scrolling
This PR throttles event handler on value change side only (prevent default/stop propagation still called all the time

Screenshots

With 100ms wait time, trackpad

Screen.Recording.2025-01-29.at.10.21.52.mp4

Testing

A) Those without trackpad
See #6539, test with mouse wheel ensure it works similar to/same as before

B) Those with trackpad
#6539

Desktop

  • OS:
  • OS Version:
  • FreeTube version:

Additional context

I tested 50ms wait and it seems too fast
(Too lazy to record that too

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) January 29, 2025 02:24
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jan 29, 2025
@PikachuEXE
Copy link
Collaborator Author

PikachuEXE commented Jan 29, 2025

Custom build: https://github.com/PikachuEXE/FreeTube/actions/runs/13023462048

@PikachuEXE PikachuEXE mentioned this pull request Jan 29, 2025
Closed
6 tasks
@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Jan 30, 2025

it seems slow but that could be because im testing on a trackpad

@PikachuEXE
Copy link
Collaborator Author

PikachuEXE commented Jan 31, 2025

Feel free to change the 100ms values to something else to see how it feels
To me 50ms seems too fast (on macOS trackpad
No idea how other OSes handle trackpad scrolling

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Jan 31, 2025

I let the others chime into this one as i find it difficult to evaluate what a good speed for this is

@PikachuEXE
Copy link
Collaborator Author

PikachuEXE commented Feb 1, 2025

I rarely use trackpad not to mention scrolling
So same as you

@github-actions
Copy link
Contributor

github-actions bot commented Feb 18, 2025

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@NgigaN

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Mar 17, 2025

@absidue @ChunkyProgrammer @kommunarr your input is needed

@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2025

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@ChunkyProgrammer
Copy link
Member

ChunkyProgrammer commented Apr 8, 2025

@absidue @ChunkyProgrammer @kommunarr your input is needed

I don't have a laptop so I can't really test this/suggest a good speed

@github-actions github-actions bot added PR: merge conflicts / rebase needed and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Apr 12, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 12, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@checktext00
Copy link

checktext00 commented Apr 16, 2025

scrolling rate/speed is perfect with the new build,

but, there is a a bit of rubber-banding feeling with the scrolling (like I could scroll the volume from 50% to 100%, but it will settle on 95%), and also it doesn't always scroll smoothly, but that's not a major issue.

also there is still the lack of ability to reverse the scrolling direction for the following 3 settings in the FreeTube app settings > Player section:

  • Scroll Volume Over Video Player
  • Scroll Playback Rate Over Video Player
  • Skip by Scrolling Over Video Player

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Apr 16, 2025

@PikachuEXE can you rebase into dev. Im having playback issues

@PikachuEXE PikachuEXE force-pushed the fix/trackpad-scroll-too-fast branch from 08f9b5e to 8007c4e Compare April 17, 2025 00:03
@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels May 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 22, 2025

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2025

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@PikachuEXE
Merge branch 'development' into fix/trackpad-scroll-too-fast
218ad97 
* development: (168 commits)
  Bump stefanzweifel/git-auto-commit-action from 5 to 6 (FreeTubeApp#7564)
  Translated using Weblate (Swedish)
  Bump the eslint group with 3 updates (FreeTubeApp#7567)
  Bump sass from 1.89.1 to 1.89.2 (FreeTubeApp#7565)
  Bump shaka-player from 4.14.15 to 4.14.18 (FreeTubeApp#7566)
  Bump postcss from 8.5.4 to 8.5.5 in the stylelint group (FreeTubeApp#7568)
  Bump electron-builder from 26.0.16 to 26.0.17 (FreeTubeApp#7569)
  Translated using Weblate (English (United Kingdom))
  add beta to asset name (FreeTubeApp#7512)
  Translated using Weblate (Dutch)
  Translated using Weblate (Dutch)
  Fix builds failing due to broken Weblate keys (FreeTubeApp#7560)
  Translated using Weblate (Persian)
  Translated using Weblate (Welsh)
  Migrate FtListVideoLazy to the composition API (FreeTubeApp#7534)
  Bump electron-builder from 26.0.15 to 26.0.16 (FreeTubeApp#7539)
  Bump eslint-plugin-vue from 10.1.0 to 10.2.0 in the eslint group (FreeTubeApp#7537)
  Bump webpack-dev-server from 5.2.1 to 5.2.2 (FreeTubeApp#7538)
  Bump electron from 36.3.2 to 36.4.0 (FreeTubeApp#7540)
  Translated using Weblate (Hungarian)
  ...
@PikachuEXE
* Only apply scroll throttle when delta value is small (assumed to be…
63a6a31 
… from touchpad), update throttle wait 100 > 200ms
@PikachuEXE
Copy link
Collaborator Author

PikachuEXE commented Jun 17, 2025

Update: Only apply scroll throttle when delta value is small (assumed to be from touchpad), update throttle wait 100 > 200ms

@PikachuEXE PikachuEXE added PR: waiting for review For PRs that are complete, tested, and ready for review and removed PR: changes requested PR: WIP labels Jun 17, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2025

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 24, 2025

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@FreeTubeBot FreeTubeBot merged commit 56046b9 into FreeTubeApp:development Jul 28, 2025
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Jul 28, 2025
@PikachuEXE PikachuEXE deleted the fix/trackpad-scroll-too-fast branch July 28, 2025 03:12
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Jul 29, 2025
@PikachuEXE
Merge branch 'development' into sabr-pika-2
215cc65 
* development: (192 commits)
  Translated using Weblate (Japanese)
  Fix scroll to seek/change volume/playback rate changing too fast with touchpad (FreeTubeApp#6666)
  Move General section within the Distraction Free Settings to top (FreeTubeApp#7719)
  Fix deleted videos appears when another video added to another playlist (FreeTubeApp#7681)
  Change Settings order (FreeTubeApp#7722)
  Migrate Subscriptions{Videos,Live,Shorts,Posts} to the composition API (FreeTubeApp#7717)
  Translated using Weblate (Romanian)
  Translated using Weblate (German)
  Migrate the FtToggleSwitch component to the composition API (FreeTubeApp#7740)
  Add missing FontAwesomeIcon imports to `<script setup>` components (FreeTubeApp#7739)
  Translated using Weblate (Spanish)
  Translated using Weblate (French)
  Translated using Weblate (Basque)
  Translated using Weblate (Chinese (Simplified Han script))
  Translated using Weblate (Breton)
  Translated using Weblate (Estonian)
  Translated using Weblate (Italian)
  Translated using Weblate (Tamil)
  Translated using Weblate (Czech)
  Translated using Weblate (Hungarian)
  ...

# Conflicts:
#	package.json
#	src/renderer/components/ft-shaka-video-player/ft-shaka-video-player.js
#	src/renderer/helpers/api/local.js
#	yarn.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@absidue absidue absidue approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@ChunkyProgrammer ChunkyProgrammer ChunkyProgrammer approved these changes

@kommunarr kommunarr Awaiting requested review from kommunarr

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: two-finger scrolling issues with touchpad

7 participants

@PikachuEXE @efb4f5ff-1298-471a-8973-3d47447115dc @NgigaN @ChunkyProgrammer @checktext00 @absidue @FreeTubeBot