Add null-check for RichShelf playlist url #6843
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
|
Mark as draft since we can't test yet? |
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: WIP
PR/Issue: dependent
and removed
PR: waiting for review
ChunkyProgrammer
force-pushed
the
add-null-check-for-playlist-url
branch
from
6f6094a to
43ec6d4
Compare
ChunkyProgrammer
added
PR: waiting for review
|
I set this PR as ready for review since url is defined as nullable in YouTube.js (even without the changes from my YouTube.js PR) so this should be merged even if we can't find any issues at this moment |
ChunkyProgrammer
force-pushed
the
add-null-check-for-playlist-url
branch
from
43ec6d4 to
887caef
Compare
ChunkyProgrammer
requested review from
PikachuEXE,
absidue,
efb4f5ff-1298-471a-8973-3d47447115dc,
kommunarr and
MarmadileManteater
|
What specific screen(s) can be viewed to run the changed code? |
ChunkyProgrammer
force-pushed
the
add-null-check-for-playlist-url
branch
from
887caef to
672467b
Compare
|
I would like to test this PR. Could you provide a test channel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add null-check for RichShelf playlist url
Pull Request Type
Description
This is causing error on the music channel since it is missing the url property.
Testing
Desktop