-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Normalize margin at top of page #7040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Normalize margin at top of page #7040
Conversation
src/renderer/App.css
Outdated
margin-inline: auto; | ||
margin-block-start: -2px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is correct. Nice catch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
single banner tested
Tested with 2 banners and with this PR it looks a bit weird Before: VirtualBoxVM_HQmCcSvY1p.mp4After: VirtualBoxVM_nstpHHNVqa.mp4 |
Ugh cant get the blog banner to show up. Anyone know how to force the banner to show? Edit: nvm found the answer #2300 (comment)
|
I do think the spacing between the banners is still a bit much compared to the non mobile view. Also the spacing between the last banner and the space on the bottom seems a bit much VirtualBoxVM_a0AgcQPh8P.mp4 |
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
Normalize margin at top of page
Pull Request Type
Description
The margin above the top of each view is not consistent. Sometimes, its narrow. Other times, it is wide. This PR aims to improve consistency so that the margin at the top is always the same.
Screenshots
Testing
Compare all the different variants of the top margin
680
Desktop