Skip to content

Remove Export Playlists For Older FreeTube Versions #7195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: development
Choose a base branch
from
Open

Remove Export Playlists For Older FreeTube Versions #7195

wants to merge 6 commits into from

Conversation

efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

Remove Export Playlists For Older FreeTube Versions

Pull Request Type

  • Other - Cleanup

Related issue

Part of previous changelogs

The setting Export Playlists For Older FreeTube Versions will be deprecated in v0.24.0

Description

Removed everything related to the Export Playlists For Older FreeTube Versions setting

Testing

  • Check that normal export functionality still works
  • Check that all references to this setting has been removed

Desktop

  • OS: Ubuntu
  • OS Version: 24.04 LTS
  • FreeTube version: 21161ac

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc marked this pull request as ready for review April 13, 2025 20:53
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Apr 13, 2025
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) April 13, 2025 20:53
@PikachuEXE
Copy link
Collaborator

PikachuEXE commented Apr 13, 2025 •
edited
Loading

deprecate means going to be removed, not removing it entirely...
If the original plan is to remove in 0.24, the release note should have be written as remove

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member Author

efb4f5ff-1298-471a-8973-3d47447115dc commented Apr 14, 2025 •
edited
Loading

If the original plan is to remove in 0.24, the release note should have be written as remove

This is our original plan. I just wrote it the wrong way in the changelog. Imo its not a big deal as i think that we have given users enough time and im pretty sure that no one is using versions of FT where the playback is broken

@PikachuEXE
Copy link
Collaborator

0.24 change log should say remove
Anyway this should be merged almost right before 0.24 release not approving yet

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member Author

I noticed that there wasnt any css removed. Is there no css for this?

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added PR: WIP and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Apr 20, 2025
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

PikachuEXE
PikachuEXE reviewed Apr 23, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PikachuEXE PikachuEXE PikachuEXE left review comments

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
PR: merge conflicts / rebase needed PR: WIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@efb4f5ff-1298-471a-8973-3d47447115dc @PikachuEXE