Update PR template to prevent confusion #7368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
Collaborator
|
Ya I think the current comments in that section is confusing |
PikachuEXE
reviewed
May 6, 2025
Co-authored-by: PikachuEXE <[email protected]>
Member
Author
|
offtopic, what is the need for having the Title header within the PR body. Seems a bit redundant. We have seen many PR's coming in from people that dont change that because they think its just a header name. Maybe remove it? |
Collaborator
|
Agree, no idea why PR title is need in body, just remove |
efb4f5ff-1298-471a-8973-3d47447115dc
changed the title
efb4f5ff-1298-471a-8973-3d47447115dc
changed the title
efb4f5ff-1298-471a-8973-3d47447115dc
requested review from
ChunkyProgrammer,
MarmadileManteater,
absidue and
kommunarr
kommunarr
approved these changes
May 7, 2025
absidue
approved these changes
May 7, 2025
PikachuEXE
approved these changes
May 7, 2025
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update testing notes in PR template
Pull Request Type
Related issue
#7366
Description
The PR linked above is an example of many authors only providing how they tested the PR but now how we should test it. This PR adds a note to change that.
INPUT NEEDED: Maybe these notes need to be removed https://github.com/FreeTubeApp/FreeTube/blob/development/.github/PULL_REQUEST_TEMPLATE.md?plain=1#L25-L28 in order to prevent confusion?