Pause player when opening recommended video in external player #7387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
May 9, 2025
PikachuEXE
approved these changes
May 10, 2025
kommunarr
approved these changes
May 13, 2025
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
May 15, 2025
* development: (49 commits) Bump electron from 35.2.1 to 36.2.0 (FreeTubeApp#7403) Translated using Weblate (Hebrew) Translated using Weblate (Hebrew) Translated using Weblate (Hebrew) Translated using Weblate (Hebrew) Translated using Weblate (Hebrew) Translated using Weblate (Slovak) Switch from OPEN_EXTERNAL_LINK IPC call to window.open() (FreeTubeApp#7380) Translated using Weblate (Korean) Translated using Weblate (Slovak) Translated using Weblate (Assamese) Translated using Weblate (Romanian) Translated using Weblate (Croatian) Translated using Weblate (Slovak) Translated using Weblate (Assamese) Fix typo in WRITE_TO_DEFAULT_FOLDER IPC call (FreeTubeApp#7378) Pause player when opening recommended video in external player (FreeTubeApp#7387) Migrate the PlaylistInfo component to the composition API (FreeTubeApp#7383) Migrate the PrivacySettings component to the composition API (FreeTubeApp#7397) Migrate the FtProfileSelector component to the composition API (FreeTubeApp#7388) ...
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
May 15, 2025
* custom-builds/current: (49 commits) Bump electron from 35.2.1 to 36.2.0 (FreeTubeApp#7403) Translated using Weblate (Hebrew) Translated using Weblate (Hebrew) Translated using Weblate (Hebrew) Translated using Weblate (Hebrew) Translated using Weblate (Hebrew) Translated using Weblate (Slovak) Switch from OPEN_EXTERNAL_LINK IPC call to window.open() (FreeTubeApp#7380) Translated using Weblate (Korean) Translated using Weblate (Slovak) Translated using Weblate (Assamese) Translated using Weblate (Romanian) Translated using Weblate (Croatian) Translated using Weblate (Slovak) Translated using Weblate (Assamese) Fix typo in WRITE_TO_DEFAULT_FOLDER IPC call (FreeTubeApp#7378) Pause player when opening recommended video in external player (FreeTubeApp#7387) Migrate the PlaylistInfo component to the composition API (FreeTubeApp#7383) Migrate the PrivacySettings component to the composition API (FreeTubeApp#7397) Migrate the FtProfileSelector component to the composition API (FreeTubeApp#7388) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
When you open the currently playing video in an external player or open a video from the playlist box, we pause the video player. At the moment we don't do that when you open a video from the recommended videos list in an external player, this pull request rectifies that.
Testing
You can pick any external player in the external player settings, you do not have to set it up properly (e.g installing it or configuring the path to it) as the pausing happens before FreeTube launches the external player.
Open a video and click on the open in external player button for one of the videos in the recommended list, the player should pause.
Desktop