Skip to content

🚧 Inject format string by tmuxf - #45

Merged
Freed-Wu merged 1 commit into
mainfrom
tmuxf
Jul 12, 2026
Merged

🚧 Inject format string by tmuxf#45
Freed-Wu merged 1 commit into
mainfrom
tmuxf

Conversation

@Freed-Wu

Copy link
Copy Markdown
Owner

Currently, in order to handle tmux format string, many complex code are written, which increase large build time (9-12s) and difficulty for maintenance. By injecting tree-sitter-tmuxf, these code can be deleted.

@mergify

mergify Bot commented Jul 11, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@coderabbitai

coderabbitai Bot commented Jul 11, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@Freed-Wu, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 30 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 660d4622-6030-43ec-8fa7-33065cb66f77

📥 Commits

Reviewing files that changed from the base of the PR and between 0507eeb and 6bb299a.

📒 Files selected for processing (25)
  • grammar.js
  • queries/highlights.scm
  • queries/injections.scm
  • src/grammar.json
  • src/node-types.json
  • src/parser.c
  • test/corpus/bind.txt
  • test/corpus/command-separator.txt
  • test/corpus/comment.txt
  • test/corpus/compound-statements.txt
  • test/corpus/if-shell.txt
  • test/corpus/if-statement.txt
  • test/corpus/new-session.txt
  • test/corpus/new-window.txt
  • test/corpus/refresh-client.txt
  • test/corpus/resize-pane.txt
  • test/corpus/run-shell.txt
  • test/corpus/select-pane.txt
  • test/corpus/select-window.txt
  • test/corpus/send-key.txt
  • test/corpus/set.txt
  • test/corpus/shell-rest.txt
  • test/corpus/split-window.txt
  • test/corpus/string.txt
  • test/corpus/variable.txt
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch tmuxf

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Freed-Wu

Freed-Wu commented Jul 12, 2026

Copy link
Copy Markdown
Owner Author

tmux support string concat, such as:

if 'true &'"& tru"\065 {
  set -g @foo foo
}

It will be concated to true && true, a legel bash syntax.

A related unit test:

bind -T\033'1'"2" v split-window -h

However, it bring confusion to injection.
What string we should treat as bash?
'true &'"& tru"\065? or true &, & tru, \065?

Although tmux support this syntax, we shouldn't use it. Only support single quoted, double quoted and bared word is enough.

For tmux format string, the problem is same: '#{host'"_name}".

Remove support of mixed string
Inject shell by bash

Currently, in order to handle tmux format string, many complex code are written, which increase large build time (9-12s) and difficulty for maintenance. By injecting tree-sitter-tmuxf, these code can be deleted.
@Freed-Wu
Freed-Wu merged commit 72be3b7 into main Jul 12, 2026
18 checks passed
@Freed-Wu
Freed-Wu deleted the tmuxf branch July 12, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant