Added "Share Replay" Button, Icon, and Download Feature #2676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@yousefsassy As indicated in the "contribution" guide, usually try not to poke at issues that have the "brainstorm" tag and/or are in a too far away milestone. This is pretty good, but will need a bit more work, will tweak original specs, contribute a bit to the PR myself and request a few more tweaks from you as well pretty soon 🐻👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes issue #1779.
This PR addresses Issue #1779 by adding a "Share Replay" button to the scoreboard screen. The changes include:
share.svgicon added toassets/interface/for the button.The ability for users to download match replay logs in JSON format.
The button’s size and alignment have been matched with the "Flee Match" button for consistency.
Changes made:
index.ejs: Implemented the "Share Replay" button and wired the functionality for exporting replay logs.assets/interface: Addedshare.svgicon used for the button.styles.less: Ensured the "Share Replay" button has the same size and positioning as the "Flee Match" button.interface.js: Added logic to enable downloading of replay logs in JSON format when the "Share Replay" button is clicked.Wallet address:
0x0000000000000000000000000000000000000000