Skip to content

Add blocking unit-test gates for PRs and NuGet releases #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Freezor merged 1 commit into from
Mar 27, 2026
Merged

Add blocking unit-test gates for PRs and NuGet releases #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 55 additions & 0 deletions .github/workflows/pr-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
name: PR Unit Tests

on:
pull_request:
branches:
- "**"

jobs:
test-gate:
name: PR Test Gate
runs-on: ubuntu-latest

steps:
- name: Checkout
uses: actions/checkout@v6

- name: Setup .NET
uses: actions/setup-dotnet@v5
with:
dotnet-version: '10.0.x'
cache: true
cache-dependency-path: |
FluentAAS/**/*.csproj
FluentAAS/global.json

- name: Locate solution file
id: solution
shell: bash
run: |
SOLUTION=$(find . -maxdepth 5 -name "*.sln" | head -n 1)
if [ -z "$SOLUTION" ]; then
echo "❌ No solution file (*.sln) found in the repo."
exit 1
fi
echo "SOLUTION_PATH=$SOLUTION" >> $GITHUB_OUTPUT
echo "✅ Found solution: $SOLUTION"

- name: Restore dependencies
run: dotnet restore "${{ steps.solution.outputs.SOLUTION_PATH }}"

- name: Build solution
run: dotnet build "${{ steps.solution.outputs.SOLUTION_PATH }}" -c Release --no-restore

# Blocking PR gate: reviewers can see this check and it must pass before merge.
- name: Run unit tests (blocking gate)
run: dotnet test "${{ steps.solution.outputs.SOLUTION_PATH }}" -c Release --no-build --verbosity normal --logger "trx;LogFileName=test-results.trx"

- name: Upload test result artifacts
if: always()
uses: actions/upload-artifact@v7
with:
name: pr-test-results
path: |
**/TestResults/*.trx
**/test-results.trx
53 changes: 46 additions & 7 deletions .github/workflows/release-nuget.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,50 @@ on:
default: "main"

jobs:
# Blocking gate: all tests must pass before any packing/publishing can run.
test-gate:
runs-on: ubuntu-latest

steps:
- name: Checkout
uses: actions/checkout@v6
with:
fetch-depth: 0
ref: ${{ inputs.ref || github.ref }}

@chatgpt-codex-connector chatgpt-codex-connector Bot Mar 27, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Pin build job to the tested commit SHA

In .github/workflows/release-nuget.yml, the new test-gate and existing build-pack-push jobs each run their own checkout from ${{ inputs.ref || github.ref }}; for workflow_dispatch this defaults to main, which is mutable. That means if main advances after test-gate passes but before build-pack-push starts, the package can be built/published from a different commit than the one that was tested, which breaks the intended hard gate. To keep the gate trustworthy, resolve and pass a specific commit SHA from test-gate to build-pack-push and checkout that SHA in the second job.

Useful? React with 👍 / 👎.


- name: Setup .NET
uses: actions/setup-dotnet@v5
with:
dotnet-version: '10.0.x'
cache: true
cache-dependency-path: |
FluentAAS/**/*.csproj
FluentAAS/global.json

- name: Locate solution file
id: solution
shell: bash
run: |
SOLUTION=$(find . -maxdepth 5 -name "*.sln" | head -n 1)
if [ -z "$SOLUTION" ]; then
echo "❌ No solution file (*.sln) found in the repo."
exit 1
fi
echo "SOLUTION_PATH=$SOLUTION" >> $GITHUB_OUTPUT
echo "✅ Found solution: $SOLUTION"

- name: Restore dependencies
run: dotnet restore "${{ steps.solution.outputs.SOLUTION_PATH }}"

- name: Build solution
run: dotnet build "${{ steps.solution.outputs.SOLUTION_PATH }}" -c Release --no-restore

- name: Test solution (blocking gate)
run: dotnet test "${{ steps.solution.outputs.SOLUTION_PATH }}" -c Release --no-build --verbosity normal

build-pack-push:
runs-on: ubuntu-latest
needs: test-gate

steps:
- name: Checkout
Expand Down Expand Up @@ -85,9 +127,6 @@ jobs:
- name: Build solution
run: dotnet build "${{ steps.solution.outputs.SOLUTION_PATH }}" -c Release --no-restore

- name: Test solution
run: dotnet test "${{ steps.solution.outputs.SOLUTION_PATH }}" -c Release --no-build --verbosity normal

- name: Pack NuGet packages
run: dotnet pack "${{ steps.solution.outputs.SOLUTION_PATH }}" -c Release -o ./artifacts --no-build /p:PackageVersion=${{ steps.version.outputs.VERSION }}

Expand All @@ -96,16 +135,16 @@ jobs:
run: |
shopt -s nullglob
packages=(./artifacts/*.nupkg)

if [ ${#packages[@]} -eq 0 ]; then
echo "❌ No NuGet packages found in ./artifacts/"
exit 1
fi

echo "📦 Generated NuGet packages:"
VERSION="${{ steps.version.outputs.VERSION }}"
ESCAPED_VERSION="${VERSION//./\\.}"

for pkg in "${packages[@]}"; do
filename=$(basename "$pkg")
echo " - $filename"
Expand Down Expand Up @@ -149,4 +188,4 @@ jobs:
prerelease: false
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GITHUB_REPOSITORY: ${{ github.repository }}
GITHUB_REPOSITORY: ${{ github.repository }}