Better DX error handling when misuse of SymfonyExtension config#29
Open
symfonyaml wants to merge 1 commit intoFriendsOfBehat:masterfrom
Open
Better DX error handling when misuse of SymfonyExtension config#29symfonyaml wants to merge 1 commit intoFriendsOfBehat:masterfrom
symfonyaml wants to merge 1 commit intoFriendsOfBehat:masterfrom
Conversation
Member
|
A better implementation of the fix would be to run the normalization step only for arrays by replacing the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
As a dummy symfony user, when I don't use the
MinkExtensioncorrectly with the following configwe have the following PHP fatal error :
Reproduce
Solution
Checking that the config is an array, so we get this error instead :
