-
Notifications
You must be signed in to change notification settings - Fork 34
[BC break] Remove Goutte support #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,4 +8,4 @@ default: | |
| base_url: http://en.wikipedia.org/ | ||
| sessions: | ||
| default: | ||
| goutte: ~ | ||
| browserkit_http: ~ | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -50,7 +50,7 @@ The easiest way to keep your suite updated is to use `Composer <http://getcompos | |
| base_url: 'http://example.com' | ||
| sessions: | ||
| default: | ||
| goutte: ~ | ||
| browserkit_http: ~ | ||
|
|
||
| Usage | ||
| ----- | ||
|
|
@@ -143,7 +143,7 @@ will need to choose the driver you want to use. | |
| first_session: | ||
| selenium2: ~ | ||
| second_session: | ||
| goutte: ~ | ||
| browserkit_http: ~ | ||
| third_session: | ||
| selenium2: ~ | ||
|
|
||
|
|
@@ -171,16 +171,16 @@ session using a javascript driver in the order of the configuration (it would | |
| be ``first_session`` in the example above as ``selenium2`` supports Javascript). | ||
| If it is not configured explicitly, the default session is set to the first | ||
| session using a non-javascript driver if any, or to the first javascript session | ||
| otherwise (it would be ``second_session`` above as ``goutte`` does not support | ||
| otherwise (it would be ``second_session`` above as ``browserkit_http`` does not support | ||
| javascript). | ||
|
|
||
| Drivers | ||
| ~~~~~~~ | ||
|
|
||
| First of all, there are drivers enabling configuration. MinkExtension comes | ||
| with support for 7 drivers out of the box: | ||
| with support for different drivers. | ||
|
|
||
| * ``GoutteDriver`` - headless driver without JavaScript support. In order to use | ||
| * ``BrowserKitDriver`` - headless driver without JavaScript support. In order to use | ||
| it, modify your ``behat.yml`` profile: | ||
|
|
||
| .. code-block:: yaml | ||
|
|
@@ -190,38 +190,7 @@ with support for 7 drivers out of the box: | |
| Behat\MinkExtension: | ||
| sessions: | ||
| my_session: | ||
| goutte: ~ | ||
|
|
||
| .. Tips : HTTPS and self-signed certificate | ||
| If you use Behat/Mink/Goutte to test your application, and want to test an | ||
| application secured with HTTPS, but with a self-signed certificate, you can use | ||
| the following parameters to avoid the validation error triggered by Guzzle: | ||
|
|
||
| * For ``Guzzle 4`` or later: | ||
|
|
||
| .. code-block:: yaml | ||
|
|
||
| default: | ||
| extensions: | ||
| Behat\MinkExtension: | ||
| sessions: | ||
| my_session: | ||
| goutte: | ||
| guzzle_parameters: | ||
| verify: false | ||
|
|
||
| * For ``Guzzle 3`` or earlier: | ||
|
|
||
| .. code-block:: yaml | ||
|
|
||
| default: | ||
| extensions: | ||
| Behat\MinkExtension: | ||
| sessions: | ||
| my_session: | ||
| goutte: | ||
| guzzle_parameters: | ||
| ssl.certificate_authority: false | ||
| browserkit_http: ~ | ||
|
|
||
| * ``Selenium2Driver`` - javascript driver. In order to use it, modify your | ||
| ``behat.yml`` profile: | ||
|
|
@@ -301,12 +270,9 @@ with support for 7 drivers out of the box: | |
|
|
||
| .. note:: | ||
|
|
||
| The phar version of Mink comes bundled with all 5 drivers and you don't need to do | ||
| anything except enabling them in order to use them. | ||
|
Comment on lines
-304
to
-305
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we support Mink PHAR version or why have you removed this part of the docs?
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I have never seen a .phar being built or provided in this repo here, so I dropped any remarks regarding a PHAR version There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I haven't either. |
||
| You need to install drivers that you need through Composer: | ||
|
|
||
| But if you're using Composer, you need to install drivers that you need first: | ||
|
|
||
| - GoutteDriver - ``behat/mink-goutte-driver`` | ||
| - BrowserKitDriver - ``behat/mink-browserkit-driver`` | ||
| - SeleniumDriver - ``behat/mink-selenium-driver`` | ||
| - Selenium2Driver (also used for SauceLabs and BrowserStack) - ``behat/mink-selenium2-driver`` | ||
| - SahiDriver - ``behat/mink-sahi-driver`` | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why were parts about Guzzle support removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought that was just special configuration for Goutte-with-Guzzle-X, wasn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're correct.